pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary Windows-specific basebackup code.
Date: Fri, 22 Jul 2022 05:43:16 +0000
Message-ID: <E1oElRT-000giz-9t@gemulon.postgresql.org> (raw)

Remove unnecessary Windows-specific basebackup code.

Commit c6f2f016 added an explicit check for a Windows "junction point".
That turned out to be needed only because get_dirent_type() was busted
on Windows.  It's been fixed by commit 9d3444dc, so remove it.

Add a TAP-test to demonstrate that in-place tablespaces are copied by
pg_basebackup.  This exercises the codepath that would fail before
c6f2f016 on Windows, and shows that it still doesn't fail now that we're
using get_dirent_type() on both Windows and Unix.

Back-patch to 15, where in-place tablespaces arrived and caused this
problem (ie directories where previously only symlinks were expected).

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5344723755bdbb13d5271ccea181166327c63e97

Modified Files
--------------
src/backend/access/transam/xlog.c            |  5 -----
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 17 +++++++++++++++++
2 files changed, 17 insertions(+), 5 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oElRT-000giz-9t@gemulon.postgresql.org>
Permalink:  ../E1oElRT-000giz-9t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oElRT-000giz-9t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove unnecessary Windows-specific basebackup code.
  In-Reply-To: <E1oElRT-000giz-9t@gemulon.postgresql.org>
  References: <E1oElRT-000giz-9t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox