pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add test for session_preload_libraries and parameter permissions
Date: Mon, 25 Jul 2022 19:45:36 +0000
Message-ID: <E1oG41H-001EQ5-KM@gemulon.postgresql.org> (raw)

Add test for session_preload_libraries and parameter permissions checks.

We weren't exercising the session_preload_libraries option in any
meaningful way.  auto_explain is a good testbed for doing so, since
it's one of the primary use-cases for session_preload_libraries.
Hence, adjust its TAP test to load the library via
session_preload_libraries not shared_preload_libraries.  While at it,
feed test-specific settings to the backend via PGOPTIONS rather than
tediously rewriting postgresql.conf.

Also, since auto_explain has some PGC_SUSET parameters, we can use it
to provide a test case for the permissions-checking bug just fixed
by commit b35617de3.

Back-patch to v15 so that we have coverage for the permissions issue
in that branch too.  To do that, I back-patched the refactoring
recently done by commit 550bc0a6c.

Dagfinn Ilmari Mannsåker and Tom Lane

Discussion: https://postgr.es/m/CABwTF4VEpwTHhRQ+q5MiC5ucngN-whN-PdcKeufX7eLSoAfbZA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c34555f8c39eeefcc45b3c3f027d7a063d738fc

Modified Files
--------------
contrib/auto_explain/t/001_auto_explain.pl | 74 +++++++++++++++++++-----------
1 file changed, 48 insertions(+), 26 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oG41H-001EQ5-KM@gemulon.postgresql.org>
Permalink:  ../E1oG41H-001EQ5-KM@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oG41H-001EQ5-KM@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add test for session_preload_libraries and parameter permissions
  In-Reply-To: <E1oG41H-001EQ5-KM@gemulon.postgresql.org>
  References: <E1oG41H-001EQ5-KM@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox