pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add test for session_preload_libraries and parameter permissions 2+ messages / 1 participants [nested] [flat]
* pgsql: Add test for session_preload_libraries and parameter permissions @ 2022-07-25 19:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-25 19:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add test for session_preload_libraries and parameter permissions checks. We weren't exercising the session_preload_libraries option in any meaningful way. auto_explain is a good testbed for doing so, since it's one of the primary use-cases for session_preload_libraries. Hence, adjust its TAP test to load the library via session_preload_libraries not shared_preload_libraries. While at it, feed test-specific settings to the backend via PGOPTIONS rather than tediously rewriting postgresql.conf. Also, since auto_explain has some PGC_SUSET parameters, we can use it to provide a test case for the permissions-checking bug just fixed by commit b35617de3. Back-patch to v15 so that we have coverage for the permissions issue in that branch too. To do that, I back-patched the refactoring recently done by commit 550bc0a6c. Dagfinn Ilmari Mannsåker and Tom Lane Discussion: https://postgr.es/m/CABwTF4VEpwTHhRQ+q5MiC5ucngN-whN-PdcKeufX7eLSoAfbZA@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7c34555f8c39eeefcc45b3c3f027d7a063d738fc Modified Files -------------- contrib/auto_explain/t/001_auto_explain.pl | 74 +++++++++++++++++++----------- 1 file changed, 48 insertions(+), 26 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add test for session_preload_libraries and parameter permissions @ 2022-07-25 19:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-07-25 19:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add test for session_preload_libraries and parameter permissions checks. We weren't exercising the session_preload_libraries option in any meaningful way. auto_explain is a good testbed for doing so, since it's one of the primary use-cases for session_preload_libraries. Hence, adjust its TAP test to load the library via session_preload_libraries not shared_preload_libraries. While at it, feed test-specific settings to the backend via PGOPTIONS rather than tediously rewriting postgresql.conf. Also, since auto_explain has some PGC_SUSET parameters, we can use it to provide a test case for the permissions-checking bug just fixed by commit b35617de3. Back-patch to v15 so that we have coverage for the permissions issue in that branch too. To do that, I back-patched the refactoring recently done by commit 550bc0a6c. Dagfinn Ilmari Mannsåker and Tom Lane Discussion: https://postgr.es/m/CABwTF4VEpwTHhRQ+q5MiC5ucngN-whN-PdcKeufX7eLSoAfbZA@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e1bd4990b2b599b2de7ae531516660c86fbb910b Modified Files -------------- contrib/auto_explain/t/001_auto_explain.pl | 125 +++++++++++++++++++++++++---- 1 file changed, 108 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-25 19:45 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-25 19:45 pgsql: Add test for session_preload_libraries and parameter permissions Tom Lane <tgl@sss.pgh.pa.us> 2022-07-25 19:45 pgsql: Add test for session_preload_libraries and parameter permissions Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox