pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Force immediate commit after CREATE DATABASE etc in extended pro
Date: Tue, 26 Jul 2022 17:07:23 +0000
Message-ID: <E1oGO1i-001MiI-KV@gemulon.postgresql.org> (raw)

Force immediate commit after CREATE DATABASE etc in extended protocol.

We have a few commands that "can't run in a transaction block",
meaning that if they complete their processing but then we fail
to COMMIT, we'll be left with inconsistent on-disk state.
However, the existing defenses for this are only watertight for
simple query protocol.  In extended protocol, we didn't commit
until receiving a Sync message.  Since the client is allowed to
issue another command instead of Sync, we're in trouble if that
command fails or is an explicit ROLLBACK.  In any case, sitting
in an inconsistent state while waiting for a client message
that might not come seems pretty risky.

This case wasn't reachable via libpq before we introduced pipeline
mode, but it's always been an intended aspect of extended query
protocol, and likely there are other clients that could reach it
before.

To fix, set a flag in PreventInTransactionBlock that tells
exec_execute_message to force an immediate commit.  This seems
to be the approach that does least damage to existing working
cases while still preventing the undesirable outcomes.

While here, add some documentation to protocol.sgml that explicitly
says how to use pipelining.  That's latent in the existing docs if
you know what to look for, but it's better to spell it out; and it
provides a place to document this new behavior.

Per bug #17434 from Yugo Nagata.  It's been wrong for ages,
so back-patch to all supported branches.

Discussion: https://postgr.es/m/17434-d9f7a064ce2a88a3@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f92944137cdec3e80e826879d817a2d3dff68b5f

Modified Files
--------------
doc/src/sgml/protocol.sgml        | 58 +++++++++++++++++++++++++++++++++++++++
src/backend/access/transam/xact.c | 14 +++++++++-
src/backend/tcop/postgres.c       | 52 ++++++++++++++++++-----------------
src/include/access/xact.h         |  6 ++++
4 files changed, 104 insertions(+), 26 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oGO1i-001MiI-KV@gemulon.postgresql.org>
Permalink:  ../E1oGO1i-001MiI-KV@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oGO1i-001MiI-KV@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Force immediate commit after CREATE DATABASE etc in extended pro
  In-Reply-To: <E1oGO1i-001MiI-KV@gemulon.postgresql.org>
  References: <E1oGO1i-001MiI-KV@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox