pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Tue, 26 Jul 2022 19:10:22 +0000
Message-ID: <E1oGPwj-001NZa-73@gemulon.postgresql.org> (raw)

Remove the restriction that the relmap must be 512 bytes.

Instead of relying on the ability to atomically overwrite the
entire relmap file in one shot, write a new one and durably
rename it into place. Removing the struct padding and the
calculation showing why the map is exactly 512 bytes, and change
the maximum number of entries to a nearby round number.

Patch by me, reviewed by Andres Freund and Dilip Kumar.

Discussion: http://postgr.es/m/CA+TgmoZq5%3DLWDK7kHaUbmWXxcaTuw_QwafgG9dr-BaPym_U8WQ%40mail.gmail.com
Discussion: http://postgr.es/m/CAFiTN-ttOXLX75k_WzRo9ar=VvxFhrHi+rJxns997F+yvkm==A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d8cd0c6c95c0120168df93aae095df4e0682a08a

Modified Files
--------------
doc/src/sgml/monitoring.sgml            |  4 +-
src/backend/utils/activity/wait_event.c |  4 +-
src/backend/utils/cache/relmapper.c     | 94 +++++++++++++++++++--------------
src/include/utils/wait_event.h          |  2 +-
4 files changed, 58 insertions(+), 46 deletions(-)



view thread (16+ messages)  latest in thread

Message-ID: <E1oGPwj-001NZa-73@gemulon.postgresql.org>
Permalink:  ../E1oGPwj-001NZa-73@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oGPwj-001NZa-73@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
  In-Reply-To: <E1oGPwj-001NZa-73@gemulon.postgresql.org>
  References: <E1oGPwj-001NZa-73@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox