pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove Tuplesortstate.copytup function
Date: Wed, 27 Jul 2022 05:29:21 +0000
Message-ID: <E1oGZbk-001RJu-Em@gemulon.postgresql.org> (raw)

Remove Tuplesortstate.copytup function

It's currently unclear how do we split functionality between
Tuplesortstate.copytup() function and tuplesort_put*() functions.
For instance, copytup_index() and copytup_datum() return error while
tuplesort_putindextuplevalues() and tuplesort_putdatum() do their work.
This commit removes Tuplesortstate.copytup() altogether, putting the
corresponding code into tuplesort_put*().

Discussion: https://postgr.es/m/CAPpHfdvjix0Ahx-H3Jp1M2R%2B_74P-zKnGGygx4OWr%3DbUQ8BNdw%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Pavel Borisov, Maxim Orlov, Matthias van de Meent
Reviewed-by: Andres Freund, John Naylor

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d47da3162b4d77c888c895dd36e4ef9cb92fcf19

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 331 +++++++++++++++----------------------
1 file changed, 133 insertions(+), 198 deletions(-)



Message-ID: <E1oGZbk-001RJu-Em@gemulon.postgresql.org>
Permalink:  ../E1oGZbk-001RJu-Em@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oGZbk-001RJu-Em@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org
  Subject: Re: pgsql: Remove Tuplesortstate.copytup function
  In-Reply-To: <E1oGZbk-001RJu-Em@gemulon.postgresql.org>
  References: <E1oGZbk-001RJu-Em@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox