pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm.
Date: Wed, 27 Jul 2022 16:00:23 +0000
Message-ID: <E1oGjSQ-001VPn-8s@gemulon.postgresql.org> (raw)

Add missing PGDLLEXPORT markings in contrib/pg_prewarm.

After commit 089480c07, it's necessary for background worker entry
points to be marked PGDLLEXPORT, else they aren't findable by
LookupBackgroundWorkerFunction().  Since pg_prewarm lacks any
regression tests, it's not surprising its worker entry points were
overlooked.  (A quick search turned up no other such oversights.)

I added some documentation pointing out the need for this, too.

Robins Tharakan and Tom Lane

CAEP4nAzndnQv3-1QKb=D-hLoK3Rko12HHMFHHtdj2GQAUXO3gw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/03361a368e7bf909283cc7721af004317fdabd3d

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c |  4 ++--
doc/src/sgml/bgworker.sgml       | 11 ++++++-----
2 files changed, 8 insertions(+), 7 deletions(-)



Message-ID: <E1oGjSQ-001VPn-8s@gemulon.postgresql.org>
Permalink:  ../E1oGjSQ-001VPn-8s@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oGjSQ-001VPn-8s@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm.
  In-Reply-To: <E1oGjSQ-001VPn-8s@gemulon.postgresql.org>
  References: <E1oGjSQ-001VPn-8s@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox