pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up some residual confusion between OIDs and RelFileNumbers
Date: Thu, 28 Jul 2022 14:27:32 +0000
Message-ID: <E1oH4U7-001dwx-2P@gemulon.postgresql.org> (raw)

Clean up some residual confusion between OIDs and RelFileNumbers.

Commit b0a55e43299c4ea2a9a8c757f9c26352407d0ccc missed a few places
where we are referring to the number used as a part of the relation
filename as an "OID". We now want to call that a "RelFileNumber".

Some of these places actually made it sound like the OID in question
is pg_class.oid rather than pg_class.relfilenode, which is especially
good to clean up.

Dilip Kumar with some editing by me.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/851f4cc75cdd8c831f1baa9a7abf8c8248b65890

Modified Files
--------------
src/backend/commands/dbcommands.c    |  4 ++--
src/backend/replication/basebackup.c | 16 +++++++------
src/backend/storage/file/reinit.c    | 44 ++++++++++++++++++------------------
src/include/storage/reinit.h         |  3 ++-
4 files changed, 35 insertions(+), 32 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oH4U7-001dwx-2P@gemulon.postgresql.org>
Permalink:  ../E1oH4U7-001dwx-2P@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oH4U7-001dwx-2P@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Clean up some residual confusion between OIDs and RelFileNumbers
  In-Reply-To: <E1oH4U7-001dwx-2P@gemulon.postgresql.org>
  References: <E1oH4U7-001dwx-2P@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox