pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Clean up some residual confusion between OIDs and RelFileNumbers
2+ messages / 2 participants
[nested] [flat]

* pgsql: Clean up some residual confusion between OIDs and RelFileNumbers
@ 2022-07-28 14:27 Robert Haas <rhaas@postgresql.org>
  2022-07-28 14:31 ` Re: pgsql: Clean up some residual confusion between OIDs and RelFileNumbers Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 2+ messages in thread

From: Robert Haas @ 2022-07-28 14:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Clean up some residual confusion between OIDs and RelFileNumbers.

Commit b0a55e43299c4ea2a9a8c757f9c26352407d0ccc missed a few places
where we are referring to the number used as a part of the relation
filename as an "OID". We now want to call that a "RelFileNumber".

Some of these places actually made it sound like the OID in question
is pg_class.oid rather than pg_class.relfilenode, which is especially
good to clean up.

Dilip Kumar with some editing by me.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/851f4cc75cdd8c831f1baa9a7abf8c8248b65890

Modified Files
--------------
src/backend/commands/dbcommands.c    |  4 ++--
src/backend/replication/basebackup.c | 16 +++++++------
src/backend/storage/file/reinit.c    | 44 ++++++++++++++++++------------------
src/include/storage/reinit.h         |  3 ++-
4 files changed, 35 insertions(+), 32 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Clean up some residual confusion between OIDs and RelFileNumbers
  2022-07-28 14:27 pgsql: Clean up some residual confusion between OIDs and RelFileNumbers Robert Haas <rhaas@postgresql.org>
@ 2022-07-28 14:31 ` Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2022-07-28 14:31 UTC (permalink / raw)
  To: pgsql-committers <pgsql-committers@lists.postgresql.org>

On Thu, Jul 28, 2022 at 10:27 AM Robert Haas <rhaas@postgresql.org> wrote:
> Clean up some residual confusion between OIDs and RelFileNumbers.
>
> https://git.postgresql.org/pg/commitdiff/851f4cc75cdd8c831f1baa9a7abf8c8248b65890

Woops, I forget to include the discussion link in the commit message:

http://postgr.es/m/CAFiTN-uwSER21k_-WehsHe63fJTY+Bizc+Q+6S58xp4YvsJV_Q@mail.gmail.com

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-07-28 14:31 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 14:27 pgsql: Clean up some residual confusion between OIDs and RelFileNumbers Robert Haas <rhaas@postgresql.org>
2022-07-28 14:31 ` Robert Haas <robertmhaas@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox