pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix brown paper bag bug in bbe08b8869bd29d587f24ef18eb45c7d4d14a
Date: Fri, 29 Jul 2022 21:13:10 +0000
Message-ID: <E1oHXID-001pgl-Rb@gemulon.postgresql.org> (raw)

Fix brown paper bag bug in bbe08b8869bd29d587f24ef18eb45c7d4d14afca.

We must issue the TRUNCATE command first and update relfrozenxid
and relminmxid afterward; otherwise, TRUNCATE overwrites the
previously-set values.

Add a test case like I should have done the first time.

Per buildfarm report from TestUpgradeXversion.pm, by way of Tom
Lane.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43746996399541ecb5c7b188725a5f097c15ceae

Modified Files
--------------
src/bin/pg_dump/pg_dump.c              | 18 ++++++-------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 46 ++++++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+), 9 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1oHXID-001pgl-Rb@gemulon.postgresql.org>
Permalink:  ../E1oHXID-001pgl-Rb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oHXID-001pgl-Rb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Fix brown paper bag bug in bbe08b8869bd29d587f24ef18eb45c7d4d14a
  In-Reply-To: <E1oHXID-001pgl-Rb@gemulon.postgresql.org>
  References: <E1oHXID-001pgl-Rb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox