pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce 2+ messages / 1 participants [nested] [flat]
* pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce @ 2022-07-30 03:30 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2022-07-30 03:30 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revise test case added in 43746996399541ecb5c7b188725a5f097c15ceae. Instead of using command_ok() to run psql, use safe_psql(). wrasse isn't happy, and it be because of failure to pass -X to the psql invocation, which safe_psql() will do automatically. Since safe_psql() returns standard output instead of writing it to a file, this requires some changes to the incantation for running 'diff'. Test against the 'regression' database rather than 'postgres' so we test more than just one table. That also means we need to record the horizons later, after the test does "VACUUM FULL pg_largeobject". Add an ORDER BY clause to the horizon query for stability. Patch by me, reviewed by Tom Lane. Discussion: http://postgr.es/m/CA+TgmoaGBbpzgu3=du1f9zDUbkfycO0y=_uWrLFy=KKEqXWeLQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/212bdc0cbc32ae5041bf1cd609f7b7a0c8930fc3 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 62 ++++++++++++++++------------------ 1 file changed, 30 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce @ 2022-07-30 03:30 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2022-07-30 03:30 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revise test case added in 43746996399541ecb5c7b188725a5f097c15ceae. Instead of using command_ok() to run psql, use safe_psql(). wrasse isn't happy, and it be because of failure to pass -X to the psql invocation, which safe_psql() will do automatically. Since safe_psql() returns standard output instead of writing it to a file, this requires some changes to the incantation for running 'diff'. Test against the 'regression' database rather than 'postgres' so we test more than just one table. That also means we need to record the horizons later, after the test does "VACUUM FULL pg_largeobject". Add an ORDER BY clause to the horizon query for stability. Patch by me, reviewed by Tom Lane. Discussion: http://postgr.es/m/CA+TgmoaGBbpzgu3=du1f9zDUbkfycO0y=_uWrLFy=KKEqXWeLQ@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d92f2bc0dae35747387f006519a74d3058a6bcb8 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 62 ++++++++++++++++------------------ 1 file changed, 30 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-07-30 03:30 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-30 03:30 pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce Robert Haas <rhaas@postgresql.org> 2022-07-30 03:30 pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox