pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce
Date: Sat, 30 Jul 2022 03:30:25 +0000
Message-ID: <E1oHdBI-001s9e-Kh@gemulon.postgresql.org> (raw)

Revise test case added in 43746996399541ecb5c7b188725a5f097c15ceae.

Instead of using command_ok() to run psql, use safe_psql(). wrasse
isn't happy, and it be because of failure to pass -X to the psql
invocation, which safe_psql() will do automatically.

Since safe_psql() returns standard output instead of writing it to
a file, this requires some changes to the incantation for running
'diff'.

Test against the 'regression' database rather than 'postgres' so
we test more than just one table. That also means we need to record
the horizons later, after the test does "VACUUM FULL pg_largeobject".

Add an ORDER BY clause to the horizon query for stability.

Patch by me, reviewed by Tom Lane.

Discussion: http://postgr.es/m/CA+TgmoaGBbpzgu3=du1f9zDUbkfycO0y=_uWrLFy=KKEqXWeLQ@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d92f2bc0dae35747387f006519a74d3058a6bcb8

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 62 ++++++++++++++++------------------
1 file changed, 30 insertions(+), 32 deletions(-)



view thread (2+ messages)

Message-ID: <E1oHdBI-001s9e-Kh@gemulon.postgresql.org>
Permalink:  ../E1oHdBI-001s9e-Kh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oHdBI-001s9e-Kh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Revise test case added in 43746996399541ecb5c7b188725a5f097c15ce
  In-Reply-To: <E1oHdBI-001s9e-Kh@gemulon.postgresql.org>
  References: <E1oHdBI-001s9e-Kh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox