pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Adjust new pg_read_file() test cases for more portability.
Date: Sat, 30 Jul 2022 15:17:13 +0000
Message-ID: <E1oHoDI-001wbk-Al@gemulon.postgresql.org> (raw)

Adjust new pg_read_file() test cases for more portability.

It's allowed for an installation to remove postgresql.auto.conf,
so don't rely on that being present.  Instead probe whether we can
read postmaster.pid.  (If you've removed that, you broke the data
directory's multiple-postmaster interlock, not to mention pg_ctl.)
Per gripe from Michael Paquier.

Discussion: https://postgr.es/m/YuSZTsoBMObyY+vT@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d10fad96c664a503a4203fc4b5acd4e816b0158a

Modified Files
--------------
src/test/regress/expected/misc_functions.out | 14 +++++++-------
src/test/regress/sql/misc_functions.sql      | 10 +++++-----
2 files changed, 12 insertions(+), 12 deletions(-)



Message-ID: <E1oHoDI-001wbk-Al@gemulon.postgresql.org>
Permalink:  ../E1oHoDI-001wbk-Al@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oHoDI-001wbk-Al@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Adjust new pg_read_file() test cases for more portability.
  In-Reply-To: <E1oHoDI-001wbk-Al@gemulon.postgresql.org>
  References: <E1oHoDI-001wbk-Al@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox