pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix error reporting after ioctl() call with pg_upgrade --clone
Date: Mon, 01 Aug 2022 07:40:03 +0000
Message-ID: <E1oIQ1y-002DxU-La@gemulon.postgresql.org> (raw)

Fix error reporting after ioctl() call with pg_upgrade --clone

errno was not reported correctly after attempting to clone a file,
leading to incorrect error reports.  While scanning through the code, I
have not noticed any similar mistakes.

Error introduced in 3a769d8.

Author: Justin Pryzby
Discussion: https://postgr.es/m/20220731134135.GY15006@telsasoft.com
Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8b1ec7d2953273501c5cea8185b6358dc7709eb5

Modified Files
--------------
src/bin/pg_upgrade/file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1oIQ1y-002DxU-La@gemulon.postgresql.org>
Permalink:  ../E1oIQ1y-002DxU-La@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oIQ1y-002DxU-La@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix error reporting after ioctl() call with pg_upgrade --clone
  In-Reply-To: <E1oIQ1y-002DxU-La@gemulon.postgresql.org>
  References: <E1oIQ1y-002DxU-La@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox