pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Check maximum number of columns in function RTEs, too.
Date: Mon, 01 Aug 2022 16:22:58 +0000
Message-ID: <E1oIYC1-002HGi-Kd@gemulon.postgresql.org> (raw)

Check maximum number of columns in function RTEs, too.

I thought commit fd96d14d9 had plugged all the holes of this sort,
but no, function RTEs could produce oversize tuples too, either
via long coldeflists or just from multiple functions in one RTE.
(I'm pretty sure the other variants of base RTEs aren't a problem,
because they ultimately refer to either a table or a sub-SELECT,
whose widths are enforced elsewhere.  But we explicitly allow join
RTEs to be overwidth, as long as you don't try to form their
tuple result.)

Per further discussion of bug #17561.  As before, patch all branches.

Discussion: https://postgr.es/m/17561-80350151b9ad2ad4@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d947a8bd5606af4333076724d20b4cb87d386c30

Modified Files
--------------
src/backend/parser/parse_relation.c | 31 ++++++++++++++++++++++++++++++-
1 file changed, 30 insertions(+), 1 deletion(-)



view thread (7+ messages)

Message-ID: <E1oIYC1-002HGi-Kd@gemulon.postgresql.org>
Permalink:  ../E1oIYC1-002HGi-Kd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oIYC1-002HGi-Kd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Check maximum number of columns in function RTEs, too.
  In-Reply-To: <E1oIYC1-002HGi-Kd@gemulon.postgresql.org>
  References: <E1oIYC1-002HGi-Kd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox