From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Relax overly strict rules in select_outer_pathkeys_for_merge()
Date: Mon, 01 Aug 2022 23:03:09 +0000
Message-ID: <E1oIeRI-002JpW-3W@gemulon.postgresql.org> (raw)
Relax overly strict rules in select_outer_pathkeys_for_merge()
The select_outer_pathkeys_for_merge function made an attempt to build the
merge join pathkeys in the same order as query_pathkeys. This was done as
it may have led to no sort being required for an ORDER BY or GROUP BY
clause in the upper planner. However, this restriction seems overly
strict as it required that we match the query_pathkeys entirely or we
don't bother putting the merge join pathkeys in that order.
Here we relax this rule so that we use a prefix of the query_pathkeys
providing that prefix matches all of the join quals. This may provide the
upper planner with partially sorted input which will allow the use of
incremental sorts instead of full sorts.
Author: David Rowley
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/CAApHDvrtZu0PHVfDPFM4Yx3jNR2Wuwosv+T2zqa7LrhhBr2rRg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b592422095655a64d638f541df784b19b8ecf8ad
Modified Files
--------------
src/backend/optimizer/path/pathkeys.c | 40 +++++++++++++++++++++++++++++------
src/test/regress/expected/join.out | 31 +++++++++++++++++++++++++++
src/test/regress/sql/join.sql | 18 ++++++++++++++++
3 files changed, 82 insertions(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org
Subject: Re: pgsql: Relax overly strict rules in select_outer_pathkeys_for_merge()
In-Reply-To: <E1oIeRI-002JpW-3W@gemulon.postgresql.org>
References: <E1oIeRI-002JpW-3W@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox