pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reduce test runtime of src/test/modules/snapshot_too_old.
Date: Wed, 03 Aug 2022 15:15:13 +0000
Message-ID: <E1oJG5Z-0008pU-1t@gemulon.postgresql.org> (raw)

Reduce test runtime of src/test/modules/snapshot_too_old.

The sto_using_cursor and sto_using_select tests were coded to exercise
every permutation of their test steps, but AFAICS there is no value in
exercising more than one.  This matters because each permutation costs
about six seconds, thanks to the "pg_sleep(6)".  Perhaps we could
reduce that, but the useless permutations seem worth getting rid of
in any case.  (Note that sto_using_hash_index got it right already.)

While here, clean up some other sloppiness such as an unused table.

This doesn't make too much difference in interactive testing, since the
wasted time is typically masked by parallelization with other tests.
However, the buildfarm runs this as a serial step, which means we can
expect to shave ~40 seconds from every buildfarm run.  That makes it
worth back-patching.

Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c628ca3500aff8fd34949102af9a56586e7c3a34

Modified Files
--------------
.../snapshot_too_old/expected/sto_using_cursor.out | 76 ----------------------
.../snapshot_too_old/expected/sto_using_select.out | 55 ----------------
.../snapshot_too_old/specs/sto_using_cursor.spec   |  7 +-
.../snapshot_too_old/specs/sto_using_select.spec   |  7 +-
4 files changed, 8 insertions(+), 137 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oJG5Z-0008pU-1t@gemulon.postgresql.org>
Permalink:  ../E1oJG5Z-0008pU-1t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJG5Z-0008pU-1t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Reduce test runtime of src/test/modules/snapshot_too_old.
  In-Reply-To: <E1oJG5Z-0008pU-1t@gemulon.postgresql.org>
  References: <E1oJG5Z-0008pU-1t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox