pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. 7+ messages / 1 participants [nested] [flat]
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b2694aebe33c8a664cb7fcaacc5a3fe30d120a09 Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9c92a10f5a986d155b92c8375267a630b3322429 Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8eaa4d0f3dbe2022f683cb8c90beeafbb43232fa Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c628ca3500aff8fd34949102af9a56586e7c3a34 Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1da0850f0e4e37488e4f871b60cc5fbe5276a76f Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9820032daa3311a6ffbc19d89d6ff5138d09cf71 Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. @ 2022-08-03 15:15 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-03 15:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reduce test runtime of src/test/modules/snapshot_too_old. The sto_using_cursor and sto_using_select tests were coded to exercise every permutation of their test steps, but AFAICS there is no value in exercising more than one. This matters because each permutation costs about six seconds, thanks to the "pg_sleep(6)". Perhaps we could reduce that, but the useless permutations seem worth getting rid of in any case. (Note that sto_using_hash_index got it right already.) While here, clean up some other sloppiness such as an unused table. This doesn't make too much difference in interactive testing, since the wasted time is typically masked by parallelization with other tests. However, the buildfarm runs this as a serial step, which means we can expect to shave ~40 seconds from every buildfarm run. That makes it worth back-patching. Discussion: https://postgr.es/m/2515192.1659454702@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e94c52fca6e10f227d5635112eb7f11f767f7a8d Modified Files -------------- .../snapshot_too_old/expected/sto_using_cursor.out | 76 ---------------------- .../snapshot_too_old/expected/sto_using_select.out | 55 ---------------- .../snapshot_too_old/specs/sto_using_cursor.spec | 7 +- .../snapshot_too_old/specs/sto_using_select.spec | 7 +- 4 files changed, 8 insertions(+), 137 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2022-08-03 15:15 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-03 15:15 pgsql: Reduce test runtime of src/test/modules/snapshot_too_old. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox