pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l 7+ messages / 1 participants [nested] [flat]
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6ad86feecb246f6b9d1f097e2bf777775b7c2434 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/efba7a63ffbe59790b88e3af459dfd81c742b90f Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4c7b16312ea3381b04a412c91f1e882cd928806e Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2e2f3435af8bf5a5a79b8ba423e9049b73f85ef8 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/963a6b6fa45d8f7627c14be7295f709ef92204f5 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/23edf0e8b4d1677f8e5269fb15a584155c2e08e2 Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l @ 2022-08-04 18:16 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2022-08-04 18:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop. Ordinarily the functions called in this loop ought to have plenty of CFIs themselves; but we've now seen a case where no such CFI is reached, making the loop uninterruptible. Even though that's from a recently-introduced bug, it seems prudent to install a CFI at the loop level in all branches. Per discussion of bug #17558 from Andrew Kesper (an actual fix for that bug will follow). Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/138213684ad44449449274522ab8fcf119cf848b Modified Files -------------- src/backend/executor/nodeModifyTable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2022-08-04 18:16 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us> 2022-08-04 18:16 pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox