pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l
Date: Thu, 04 Aug 2022 18:16:40 +0000
Message-ID: <E1oJfOi-000JNL-Ge@gemulon.postgresql.org> (raw)

Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop.

Ordinarily the functions called in this loop ought to have plenty
of CFIs themselves; but we've now seen a case where no such CFI is
reached, making the loop uninterruptible.  Even though that's from
a recently-introduced bug, it seems prudent to install a CFI at
the loop level in all branches.

Per discussion of bug #17558 from Andrew Kesper (an actual fix for
that bug will follow).

Discussion: https://postgr.es/m/17558-3f6599ffcf52fd4a@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ad86feecb246f6b9d1f097e2bf777775b7c2434

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oJfOi-000JNL-Ge@gemulon.postgresql.org>
Permalink:  ../E1oJfOi-000JNL-Ge@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJfOi-000JNL-Ge@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l
  In-Reply-To: <E1oJfOi-000JNL-Ge@gemulon.postgresql.org>
  References: <E1oJfOi-000JNL-Ge@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox