pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configure probe for dlopen, and refactor.
Date: Thu, 04 Aug 2022 21:59:42 +0000
Message-ID: <E1oJisX-000Kme-TX@gemulon.postgresql.org> (raw)

Remove configure probe for dlopen, and refactor.

dlopen() is in SUSv2 and all targeted Unix systems have it.  We still
need replacement functions for Windows, but we don't need a configure
probe for that.

Since it's no longer needed by other operating systems, rename dlopen.c
to win32dlopen.c and move the declarations into win32_port.h.

Likewise, the macros RTLD_NOW and RTLD_GLOBAL now only need to be
defined on Windows, since all targeted Unix systems have 'em.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ca1e85513e1c92afb80a74935cbbb6f7e4a3ccf9

Modified Files
--------------
configure                            | 43 +++++-------------------------------
configure.ac                         |  4 +---
src/backend/utils/fmgr/dfmgr.c       |  4 ++--
src/include/pg_config.h.in           | 11 ---------
src/include/port.h                   | 23 -------------------
src/include/port/win32_port.h        |  9 ++++++++
src/port/{dlopen.c => win32dlopen.c} | 10 +++------
src/tools/msvc/Mkvcbuild.pm          |  3 ++-
src/tools/msvc/Solution.pm           |  3 ---
9 files changed, 23 insertions(+), 87 deletions(-)



Message-ID: <E1oJisX-000Kme-TX@gemulon.postgresql.org>
Permalink:  ../E1oJisX-000Kme-TX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJisX-000Kme-TX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove configure probe for dlopen, and refactor.
  In-Reply-To: <E1oJisX-000Kme-TX@gemulon.postgresql.org>
  References: <E1oJisX-000Kme-TX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox