pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configure probe and related tests for getrlimit.
Date: Thu, 04 Aug 2022 21:59:42 +0000
Message-ID: <E1oJisX-000Kmf-U0@gemulon.postgresql.org> (raw)

Remove configure probe and related tests for getrlimit.

getrlimit() is in SUSv2 and all targeted systems have it.

Windows doesn't have it.  We could just use #ifndef WIN32, but for a
little more explanation about why we're making things conditional, let's
retain the HAVE_GETRLIMIT macro.  It's defined in port.h for Unix systems.

On systems that have it, it's not necessary to test for RLIMIT_CORE,
RLIMIT_STACK or RLIMIT_NOFILE macros, since SUSv2 requires those and all
targeted systems have them.  Also remove references to a pre-historic
alternative spelling of RLIMIT_NOFILE, and coding that seemed to believe
that Cygwin didn't have it.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bdb657edd6db1e471437d62f4642674a801ef32c

Modified Files
--------------
configure                     | 2 +-
configure.ac                  | 1 -
src/backend/storage/file/fd.c | 4 ----
src/backend/tcop/postgres.c   | 8 ++------
src/bin/pg_ctl/pg_ctl.c       | 8 ++++----
src/bin/pgbench/pgbench.c     | 4 ----
src/include/pg_config.h.in    | 3 ---
src/include/port.h            | 8 ++++++++
src/test/regress/pg_regress.c | 4 ++--
src/tools/msvc/Solution.pm    | 1 -
10 files changed, 17 insertions(+), 26 deletions(-)



Message-ID: <E1oJisX-000Kmf-U0@gemulon.postgresql.org>
Permalink:  ../E1oJisX-000Kmf-U0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJisX-000Kmf-U0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove configure probe and related tests for getrlimit.
  In-Reply-To: <E1oJisX-000Kmf-U0@gemulon.postgresql.org>
  References: <E1oJisX-000Kmf-U0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox