pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configure probe for link.
Date: Thu, 04 Aug 2022 21:59:42 +0000
Message-ID: <E1oJisX-000Kmq-Vs@gemulon.postgresql.org> (raw)

Remove configure probe for link.

link() is in SUSv2 and all targeted Unix systems have it.  We have
replacement code for Windows that doesn't require a configure probe.
Since only Windows needs it, rename src/port/link.c to win32link.c like
other similar things.

There is no need for a vestigial HAVE_LINK macro, because we expect all
Unix and, with our replacement function, Windows systems to have it, so
we didn't have any tests around link() usage.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5963c9a154bd5590a7ea48826d9bd72c9324e071

Modified Files
--------------
configure                        | 19 ++++++-------------
configure.ac                     |  2 +-
src/include/pg_config.h.in       |  3 ---
src/include/port.h               |  3 ++-
src/port/{link.c => win32link.c} |  8 ++------
src/tools/msvc/Mkvcbuild.pm      |  6 ++++--
src/tools/msvc/Solution.pm       |  1 -
7 files changed, 15 insertions(+), 27 deletions(-)



Message-ID: <E1oJisX-000Kmq-Vs@gemulon.postgresql.org>
Permalink:  ../E1oJisX-000Kmq-Vs@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJisX-000Kmq-Vs@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove configure probe for link.
  In-Reply-To: <E1oJisX-000Kmq-Vs@gemulon.postgresql.org>
  References: <E1oJisX-000Kmq-Vs@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox