pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
Date: Fri, 05 Aug 2022 16:04:43 +0000
Message-ID: <E1oJzoZ-000RpS-5Q@gemulon.postgresql.org> (raw)

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/49b85e4812d78b4c4601301209597a35c117b16b

Modified Files
--------------
src/backend/access/brin/brin_pageops.c        |  7 ++-
src/backend/access/brin/brin_xlog.c           |  6 +++
src/test/modules/brin/t/02_wal_consistency.pl | 64 +++++++++++++++++++++++++++
3 files changed, 76 insertions(+), 1 deletion(-)



view thread (12+ messages)  latest in thread

Message-ID: <E1oJzoZ-000RpS-5Q@gemulon.postgresql.org>
Permalink:  ../E1oJzoZ-000RpS-5Q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oJzoZ-000RpS-5Q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
  In-Reply-To: <E1oJzoZ-000RpS-5Q@gemulon.postgresql.org>
  References: <E1oJzoZ-000RpS-5Q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox