pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Partially undo commit 94da73281. 4+ messages / 1 participants [nested] [flat]
* pgsql: Partially undo commit 94da73281. @ 2022-08-05 19:57 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-08-05 19:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Partially undo commit 94da73281. On closer inspection, mcv.c isn't as broken for ScalarArrayOpExpr as I thought. The Var-on-right issue is real enough, but actually it does cope fine with a NULL array constant --- I was misled by an XXX comment suggesting it didn't. Undo that part of the code change, and replace the XXX comment with something less misleading. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4c81a50e5b6ea0bf2bc9896a6c89d16163598b43 Modified Files -------------- src/backend/statistics/extended_stats.c | 7 +++---- src/backend/statistics/mcv.c | 25 ++++++++++++++++--------- 2 files changed, 19 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Partially undo commit 94da73281. @ 2022-08-05 19:57 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-08-05 19:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Partially undo commit 94da73281. On closer inspection, mcv.c isn't as broken for ScalarArrayOpExpr as I thought. The Var-on-right issue is real enough, but actually it does cope fine with a NULL array constant --- I was misled by an XXX comment suggesting it didn't. Undo that part of the code change, and replace the XXX comment with something less misleading. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6303df08f0c4961c4e13b8e2aefab2dc1be7cd2d Modified Files -------------- src/backend/statistics/extended_stats.c | 7 +++---- src/backend/statistics/mcv.c | 25 ++++++++++++++++--------- 2 files changed, 19 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Partially undo commit 94da73281. @ 2022-08-05 19:57 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-08-05 19:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Partially undo commit 94da73281. On closer inspection, mcv.c isn't as broken for ScalarArrayOpExpr as I thought. The Var-on-right issue is real enough, but actually it does cope fine with a NULL array constant --- I was misled by an XXX comment suggesting it didn't. Undo that part of the code change, and replace the XXX comment with something less misleading. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b9243cadad55e296e83839fb96457f64dcaaeb25 Modified Files -------------- src/backend/statistics/extended_stats.c | 7 +++---- src/backend/statistics/mcv.c | 25 ++++++++++++++++--------- 2 files changed, 19 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Partially undo commit 94da73281. @ 2022-08-05 19:57 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-08-05 19:57 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Partially undo commit 94da73281. On closer inspection, mcv.c isn't as broken for ScalarArrayOpExpr as I thought. The Var-on-right issue is real enough, but actually it does cope fine with a NULL array constant --- I was misled by an XXX comment suggesting it didn't. Undo that part of the code change, and replace the XXX comment with something less misleading. Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/476f9d533084f2ad3f625b5092021b6c23c8e196 Modified Files -------------- src/backend/statistics/extended_stats.c | 7 +++---- src/backend/statistics/mcv.c | 25 ++++++++++++++++--------- 2 files changed, 19 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-08-05 19:57 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-08-05 19:57 pgsql: Partially undo commit 94da73281. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-05 19:57 pgsql: Partially undo commit 94da73281. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-05 19:57 pgsql: Partially undo commit 94da73281. Tom Lane <tgl@sss.pgh.pa.us> 2022-08-05 19:57 pgsql: Partially undo commit 94da73281. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox