pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Partially undo commit 94da73281.
Date: Fri, 05 Aug 2022 19:57:59 +0000
Message-ID: <E1oK3SJ-000TLx-4l@gemulon.postgresql.org> (raw)

Partially undo commit 94da73281.

On closer inspection, mcv.c isn't as broken for ScalarArrayOpExpr
as I thought.  The Var-on-right issue is real enough, but actually
it does cope fine with a NULL array constant --- I was misled by
an XXX comment suggesting it didn't.  Undo that part of the code
change, and replace the XXX comment with something less misleading.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b9243cadad55e296e83839fb96457f64dcaaeb25

Modified Files
--------------
src/backend/statistics/extended_stats.c |  7 +++----
src/backend/statistics/mcv.c            | 25 ++++++++++++++++---------
2 files changed, 19 insertions(+), 13 deletions(-)



view thread (4+ messages)

Message-ID: <E1oK3SJ-000TLx-4l@gemulon.postgresql.org>
Permalink:  ../E1oK3SJ-000TLx-4l@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oK3SJ-000TLx-4l@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Partially undo commit 94da73281.
  In-Reply-To: <E1oK3SJ-000TLx-4l@gemulon.postgresql.org>
  References: <E1oK3SJ-000TLx-4l@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox