From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix comments about deduplication updating page.
Date: Fri, 05 Aug 2022 21:27:01 +0000
Message-ID: <E1oK4qT-000U6I-Hn@gemulon.postgresql.org> (raw)
Fix comments about deduplication updating page.
nbtree deduplication passes add tuples from the original/target page to
a temp page, merging as necessary. The temp page is copied back to the
target permanent page in the critical section. This is similar to the
approach taken by nbtree page splits.
Adjust comments that referred to updating the original page in-place as
tuples were merged. These were left over from earlier versions of the
deduplication patch that didn't yet use a temp page.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f68faf4c7530e39e626b0aa3e4a36376e122fce7
Modified Files
--------------
src/backend/access/nbtree/nbtdedup.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie
Subject: Re: pgsql: Fix comments about deduplication updating page.
In-Reply-To: <E1oK4qT-000U6I-Hn@gemulon.postgresql.org>
References: <E1oK4qT-000U6I-Hn@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox