pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve recently-added test reliability
Date: Sat, 06 Aug 2022 13:54:00 +0000
Message-ID: <E1oKKFb-000aAO-Vn@gemulon.postgresql.org> (raw)

Improve recently-added test reliability

Commit 59be1c942a47 already tried to make
src/test/recovery/t/033_replay_tsp_drops more reliable, but it wasn't
enough.  Try to improve on that by making this use of a replication slot
to be more like others.  Also, don't drop the slot.

Make a few other stylistic changes while at it.  It's still quite slow,
which is another thing that we need to fix in this script.

Backpatch to all supported branches.

Discussion: https://postgr.es/m/349302.1659191875@sss.pgh.pa.us

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/782e5631e5ddb8c2777a8cb26ac51437b787cd70

Modified Files
--------------
src/test/recovery/t/033_replay_tsp_drops.pl | 35 +++++++++--------------------
1 file changed, 11 insertions(+), 24 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oKKFb-000aAO-Vn@gemulon.postgresql.org>
Permalink:  ../E1oKKFb-000aAO-Vn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oKKFb-000aAO-Vn@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Improve recently-added test reliability
  In-Reply-To: <E1oKKFb-000aAO-Vn@gemulon.postgresql.org>
  References: <E1oKKFb-000aAO-Vn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox