pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix function-defined-but-not-used warning.
Date: Sat, 06 Aug 2022 17:32:38 +0000
Message-ID: <E1oKNfC-000bVw-HE@gemulon.postgresql.org> (raw)

Fix function-defined-but-not-used warning.

Buildfarm member jacana (MinGW) has been complaining that
get_iso_localename is defined but not used.  This is evidently
fallout from the recent removal of VS2013 support in pg_locale.c.
Rearrange the #ifs so that get_iso_localename and its subroutine
search_locale_enum won't get built on MinGW.

I also noticed that a comment in get_iso_localename cross-
referenced a comment in IsoLocaleName that isn't there anymore.
Put back what I think is the referenced material.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c7121bcf8dbe94344742a5cd0fa0f016b7a76a1

Modified Files
--------------
src/backend/utils/adt/pg_locale.c | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)



Message-ID: <E1oKNfC-000bVw-HE@gemulon.postgresql.org>
Permalink:  ../E1oKNfC-000bVw-HE@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oKNfC-000bVw-HE@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix function-defined-but-not-used warning.
  In-Reply-To: <E1oKNfC-000bVw-HE@gemulon.postgresql.org>
  References: <E1oKNfC-000bVw-HE@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox