pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix MSVC build script's check for obsolete node support function
Date: Mon, 08 Aug 2022 18:43:42 +0000
Message-ID: <E1oL7j4-000uPy-Rt@gemulon.postgresql.org> (raw)

Fix MSVC build script's check for obsolete node support functions.

Commit 964d01ae9 was a few bricks shy of a load here: the script
checked whether gen_node_support.pl itself had been updated since it
was last run, but not whether any of its input files had been updated.
Fix that.  While here, scrape the list of input files from the
Makefiles rather than having a duplicate copy, as we do for most
other lists of source files.

In passing, improve gen_node_support.pl's error report for an
incorrect file list.

Per gripe from Amit Kapila.

Discussion: https://postgr.es/m/CAA4eK1KQk4vP-3mTAz26h-PRUZaGu8Fc=q-ZKSajsAthH0A15w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9a9f25e217428cdf4119ff08b77f9f5bd45f563c

Modified Files
--------------
src/backend/nodes/gen_node_support.pl |  2 +-
src/tools/msvc/Solution.pm            | 50 +++++++++++++++--------------------
2 files changed, 23 insertions(+), 29 deletions(-)



Message-ID: <E1oL7j4-000uPy-Rt@gemulon.postgresql.org>
Permalink:  ../E1oL7j4-000uPy-Rt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oL7j4-000uPy-Rt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix MSVC build script's check for obsolete node support function
  In-Reply-To: <E1oL7j4-000uPy-Rt@gemulon.postgresql.org>
  References: <E1oL7j4-000uPy-Rt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox