From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Fix some minor code issues
Date: Fri, 12 Aug 2022 22:18:55 +0000
Message-ID: <E1oMczW-000VS9-A5@gemulon.postgresql.org> (raw)
pg_upgrade: Fix some minor code issues
96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code. Remove that.
87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool. So this would not work correctly if there ever is a
checksum version larger than 1.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/08c5c6d2833bfae8a27ed7ab3f66513b735321bb
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org
Subject: Re: pgsql: pg_upgrade: Fix some minor code issues
In-Reply-To: <E1oMczW-000VS9-A5@gemulon.postgresql.org>
References: <E1oMczW-000VS9-A5@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox