pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pg_upgrade: Fix some minor code issues
7+ messages / 1 participants
[nested] [flat]

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9da300128df71b8f3f2a92038aee251413735dbe

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a47bf42d172a35622f5f764e663ea4f83d96c977

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e5c2feac0e09c043df8c2359688d10abe586cd52

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8e40d16e954195c7bce7070a26174fcca3164882

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/08c5c6d2833bfae8a27ed7ab3f66513b735321bb

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d0dde35ee713c7afcd24653e2cececbdf3ede0bf

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: pg_upgrade: Fix some minor code issues
@ 2022-08-12 22:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 7+ messages in thread

From: Peter Eisentraut @ 2022-08-12 22:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c7bc39cec78da20c31861ca57a4749ca3c3cfec0

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2022-08-12 22:18 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>
2022-08-12 22:18 pgsql: pg_upgrade: Fix some minor code issues Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox