pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configure probe for sys/uio.h.
Date: Sat, 13 Aug 2022 12:16:44 +0000
Message-ID: <E1oMq4I-000aeO-Rj@gemulon.postgresql.org> (raw)

Remove configure probe for sys/uio.h.

<sys/uio.h> is in SUSv2, and all targeted Unix system have it, so we
might as well drop the probe (in fact we never really needed this one).
It's where struct iovec is defined, and as a common extension, it's also
where non-standard preadv() and pwritev() are declared on systems that
have them.

We should also be able to assume that IOV_MAX is defined on Unix.

To spell out what our pg_iovec.h header does for the OSes in the build
farm as of today:

  Windows: our own struct and functions
  Solaris, Cygwin: <sys/uio.h>'s struct, our own functions
  Every other Unix: <sys/uio.h>'s struct and functions

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CA%2BhUKG%2BL_3brvh%3D8e0BW_VfX9h7MtwgN%3DnFHP5o7X2oZucY9dg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/75357ab94034c6f2e65d146632691072756365c5

Modified Files
--------------
configure                   |  2 +-
configure.ac                |  1 -
src/include/pg_config.h.in  |  3 ---
src/include/port/pg_iovec.h | 20 ++++++++------------
src/tools/msvc/Solution.pm  |  1 -
5 files changed, 9 insertions(+), 18 deletions(-)



Message-ID: <E1oMq4I-000aeO-Rj@gemulon.postgresql.org>
Permalink:  ../E1oMq4I-000aeO-Rj@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oMq4I-000aeO-Rj@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove configure probe for sys/uio.h.
  In-Reply-To: <E1oMq4I-000aeO-Rj@gemulon.postgresql.org>
  References: <E1oMq4I-000aeO-Rj@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox