pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove configurability of PPC spinlock assembly code.
Date: Sat, 13 Aug 2022 17:37:15 +0000
Message-ID: <E1oMv4T-000ceF-O5@gemulon.postgresql.org> (raw)

Remove configurability of PPC spinlock assembly code.

Assume that we can use LWARX hint flags and the LWSYNC instruction
on any PPC machine.  The check on the assembler's behavior was only
needed for Apple's old assembler, which is no longer of interest
now that we've de-supported all PPC-era versions of macOS (thanks
to them not having clock_gettime()).  Also, given an up-to-date
assembler these instructions work even on Apple's old hardware.
It seems quite unlikely that anyone would be interested in running
current Postgres on PPC hardware that's so old as to not have
these instructions.

Hence, rip out associated configure test and manual configuration
options, and just use the modernized instructions all the time.
Also, update atomics/arch-ppc.h to use these instructions as well.
(It was already using LWSYNC unconditionally in another place,
providing further proof that nobody is using PG on hardware old
enough to have a problem with that.)

Discussion: https://postgr.es/m/166622.1660323391@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ded65682bee2a1c04392a88e0df0f4fc7552623

Modified Files
--------------
configure                           | 34 +------------------------------
configure.ac                        | 13 +-----------
src/include/pg_config.h.in          |  3 ---
src/include/pg_config_manual.h      | 26 ------------------------
src/include/port/atomics/arch-ppc.h | 40 ++++++++++++++++++-------------------
src/include/storage/s_lock.h        | 24 ++++------------------
src/tools/msvc/Solution.pm          |  1 -
7 files changed, 26 insertions(+), 115 deletions(-)



Message-ID: <E1oMv4T-000ceF-O5@gemulon.postgresql.org>
Permalink:  ../E1oMv4T-000ceF-O5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oMv4T-000ceF-O5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove configurability of PPC spinlock assembly code.
  In-Reply-To: <E1oMv4T-000ceF-O5@gemulon.postgresql.org>
  References: <E1oMv4T-000ceF-O5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox