From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove HAVE_UNIX_SOCKETS.
Date: Sat, 13 Aug 2022 20:51:38 +0000
Message-ID: <E1oMy6b-000dtV-DH@gemulon.postgresql.org> (raw)
Remove HAVE_UNIX_SOCKETS.
Since HAVE_UNIX_SOCKETS is now defined unconditionally, remove the macro
and drop a small amount of dead code.
The last known systems not to have them (as far as I know at least) were
QNX, which we de-supported years ago, and Windows, which now has them.
If a new OS ever shows up with the POSIX sockets API but without working
AF_UNIX, it'll presumably still be able to compile the code, and fail at
runtime with an unsupported address family error. We might want to
consider adding a HINT that you should turn off the option to use it if
your network stack doesn't support it at that point, but it doesn't seem
worth making the relevant code conditional at compile time.
Also adjust a couple of places in the docs and comments that referred to
builds without Unix-domain sockets, since there aren't any. Windows
still gets a special mention in those places, though, because we don't
try to use them by default there yet.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/CA%2BhUKG%2BL_3brvh%3D8e0BW_VfX9h7MtwgN%3DnFHP5o7X2oZucY9dg%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f5580882856963d1b50f9e391a8dda82d44b69a6
Modified Files
--------------
doc/src/sgml/libpq.sgml | 9 ++++----
doc/src/sgml/ref/psql-ref.sgml | 2 +-
src/backend/libpq/hba.c | 10 ---------
src/backend/libpq/pqcomm.c | 18 ----------------
src/backend/postmaster/postmaster.c | 2 --
src/backend/utils/misc/guc.c | 4 ----
src/bin/initdb/initdb.c | 41 -------------------------------------
src/bin/pg_upgrade/option.c | 4 ++--
src/bin/pg_upgrade/server.c | 2 +-
src/common/ip.c | 11 ----------
src/include/port.h | 3 ---
src/interfaces/libpq/fe-connect.c | 12 -----------
src/test/regress/pg_regress.c | 24 ++++------------------
13 files changed, 12 insertions(+), 130 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tmunro@postgresql.org
Subject: Re: pgsql: Remove HAVE_UNIX_SOCKETS.
In-Reply-To: <E1oMy6b-000dtV-DH@gemulon.postgresql.org>
References: <E1oMy6b-000dtV-DH@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox