pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing bad-PGconn guards in libpq entry points.
Date: Mon, 15 Aug 2022 19:40:30 +0000
Message-ID: <E1oNfwq-000vTC-Ry@gemulon.postgresql.org> (raw)

Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing.  PQflush() and PQisnonblocking() didn't get that memo
though.  Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb9237a1295a29c4e41b97f9d34e3922ac69c071

Modified Files
--------------
src/interfaces/libpq/fe-exec.c           | 4 ++++
src/interfaces/libpq/fe-secure-openssl.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1oNfwq-000vTC-Ry@gemulon.postgresql.org>
Permalink:  ../E1oNfwq-000vTC-Ry@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oNfwq-000vTC-Ry@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Add missing bad-PGconn guards in libpq entry points.
  In-Reply-To: <E1oNfwq-000vTC-Ry@gemulon.postgresql.org>
  References: <E1oNfwq-000vTC-Ry@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox