pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refer to replication origin roident as "ID" in user facing messa
Date: Thu, 18 Aug 2022 02:10:59 +0000
Message-ID: <E1oOUzq-0002pN-Op@gemulon.postgresql.org> (raw)

Refer to replication origin roident as "ID" in user facing messages and docs

The table column that stores this is of type oid, but is actually limited
to uint16 and has a different path for creating new values. Some of
the documentation already referred to it as an ID, so let's standardize
on that.

While at it, most format strings already use %u, so for consintency
change the remaining stragglers using %d.

Per suggestions from Tom Lane and Justin Pryzby
Discussion: https://www.postgresql.org/message-id/3437166.1659620465%40sss.pgh.pa.us
Backpatch to v15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7cadaac5130ec60d905c5ad69af98056b54c4e37

Modified Files
--------------
doc/src/sgml/replication-origins.sgml    |  4 ++--
src/backend/replication/logical/origin.c | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1oOUzq-0002pN-Op@gemulon.postgresql.org>
Permalink:  ../E1oOUzq-0002pN-Op@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oOUzq-0002pN-Op@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Refer to replication origin roident as "ID" in user facing messa
  In-Reply-To: <E1oOUzq-0002pN-Op@gemulon.postgresql.org>
  References: <E1oOUzq-0002pN-Op@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox