pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix macro problem with gai_strerror on Windows.
Date: Thu, 18 Aug 2022 04:34:02 +0000
Message-ID: <E1oOXEH-0003fh-AX@gemulon.postgresql.org> (raw)

Fix macro problem with gai_strerror on Windows.

Commit 5579388d was confused about why gai_strerror() didn't work, and
used gai_strerrorA().  It turns out that we had explicitly undefined
Windows' own macro for that somewhere else.  Get rid of all that, and
use the system headers' definition of gai_sterror() directly as
intended.

Discussion: https://postgr.es/m/CA+hUKGKErNfhmvb_H0UprEmp4LPzGN06yR2_0tYikjzB-2ECMw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cce28f62680ca77f18762d58bc31f6b67c6ef692

Modified Files
--------------
src/include/port/win32/netdb.h      | 2 --
src/include/port/win32/sys/socket.h | 7 -------
2 files changed, 9 deletions(-)



Message-ID: <E1oOXEH-0003fh-AX@gemulon.postgresql.org>
Permalink:  ../E1oOXEH-0003fh-AX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oOXEH-0003fh-AX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Fix macro problem with gai_strerror on Windows.
  In-Reply-To: <E1oOXEH-0003fh-AX@gemulon.postgresql.org>
  References: <E1oOXEH-0003fh-AX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox