pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Be more careful to avoid including system headers after perl.h
Date: Sat, 27 Aug 2022 07:46:07 +0000
Message-ID: <E1oRqW7-0006ij-6V@gemulon.postgresql.org> (raw)

Be more careful to avoid including system headers after perl.h

Commit 121d2d3d70 included simd.h into pg_wchar.h. This caused a problem
on Windows, since Perl has "#define free" (referring to globals), which
breaks the Windows' header. To fix, move the static inline function
definitions from plperl_helpers.h, into plperl.h, where we already
document the necessary inclusion order. Since those functions were the
only reason for the existence of plperl_helpers.h, remove it.

First reported by Justin Pryzby

Diagnosis and review by Andres Freund, patch by myself per suggestion
from Tom Lane

Discussion: https://www.postgresql.org/message-id/20220826115546.GE2342%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4eec2e03c34f9a357d86317b1cd05d80a2ab559d

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c |   1 -
contrib/jsonb_plperl/jsonb_plperl.c   |   1 -
src/pl/plperl/GNUmakefile             |   4 +-
src/pl/plperl/SPI.xs                  |   1 -
src/pl/plperl/Util.xs                 |   1 -
src/pl/plperl/plperl.c                |   2 -
src/pl/plperl/plperl.h                | 170 ++++++++++++++++++++++++++++++++-
src/pl/plperl/plperl_helpers.h        | 171 ----------------------------------
8 files changed, 171 insertions(+), 180 deletions(-)



Message-ID: <E1oRqW7-0006ij-6V@gemulon.postgresql.org>
Permalink:  ../E1oRqW7-0006ij-6V@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oRqW7-0006ij-6V@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org
  Subject: Re: pgsql: Be more careful to avoid including system headers after perl.h
  In-Reply-To: <E1oRqW7-0006ij-6V@gemulon.postgresql.org>
  References: <E1oRqW7-0006ij-6V@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox