pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix the incorrect assertion introduced in commit 7f13ac8123.
Date: Mon, 29 Aug 2022 02:49:04 +0000
Message-ID: <E1oSUpk-000Obh-93@gemulon.postgresql.org> (raw)

Fix the incorrect assertion introduced in commit 7f13ac8123.

It has been incorrectly assumed in commit 7f13ac8123 that we can either
purge all or none in the catalog modifying xids list retrieved from a
serialized snapshot. It is quite possible that some of the xids in that
array are old enough to be pruned but not others.

As per buildfarm

Author: Amit Kapila and Masahiko Sawada
Reviwed-by: Masahiko Sawada
Discussion: https://postgr.es/m/CAA4eK1LBtv6ayE+TvCcPmC-xse=DVg=SmbyQD1nv_AaqcpUJEg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2169c998553a6945fd51b8a1e5e9e1384283fdd

Modified Files
--------------
.../expected/catalog_change_snapshot.out           | 56 +++++++++++++++++++++-
.../specs/catalog_change_snapshot.spec             | 20 ++++++++
src/backend/replication/logical/snapbuild.c        | 50 +++++++++++--------
3 files changed, 106 insertions(+), 20 deletions(-)



Message-ID: <E1oSUpk-000Obh-93@gemulon.postgresql.org>
Permalink:  ../E1oSUpk-000Obh-93@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oSUpk-000Obh-93@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Fix the incorrect assertion introduced in commit 7f13ac8123.
  In-Reply-To: <E1oSUpk-000Obh-93@gemulon.postgresql.org>
  References: <E1oSUpk-000Obh-93@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox