pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing padding from MemoryChunk struct
Date: Mon, 29 Aug 2022 11:21:25 +0000
Message-ID: <E1oScpZ-000Rp6-8a@gemulon.postgresql.org> (raw)

Add missing padding from MemoryChunk struct

Buildfarm animals skate, grison and mamba are Assert failing on the
pointer being given to repalloc not being MAXALIGNED.  c6e0fe1f2a made
changes in that area.

All of these animals are 32-bit with a MAXIMUM_ALIGNOF of 8 and a
SIZEOF_VOID_P of 4.  I suspect that the pointer is not properly aligned due
to the lack of padding in the MemoryChunk struct.

Here we add the same type of padding that was previously used in
AllocChunkData and GenerationChunk that c6e0fe1f2a neglected to add.

Discussion: https://postgr.es/m/CAA4eK1%2B1JyW5TiL%3DyV-3Uq1CrfnTyn0Xrk5uArt31Z%3D8rgPhXQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/df0f4feef8de933be61ce3e73142c82c37b17fa4

Modified Files
--------------
src/include/utils/memutils_memorychunk.h | 8 ++++++++
1 file changed, 8 insertions(+)



Message-ID: <E1oScpZ-000Rp6-8a@gemulon.postgresql.org>
Permalink:  ../E1oScpZ-000Rp6-8a@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oScpZ-000Rp6-8a@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Add missing padding from MemoryChunk struct
  In-Reply-To: <E1oScpZ-000Rp6-8a@gemulon.postgresql.org>
  References: <E1oScpZ-000Rp6-8a@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox