pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Be smarter about freeing tuples during tuplesorts
Date: Wed, 31 Aug 2022 23:08:38 +0000
Message-ID: <E1oTWp3-000pR6-KW@gemulon.postgresql.org> (raw)

Be smarter about freeing tuples during tuplesorts

During dumptuples() the call to writetuple() would pfree any non-null
tuple.  This was quite wasteful as this happens just before we perform a
reset of the context which stores all of those tuples.

It seems to make sense to do a bit of a code refactor to make this work,
so here we just get rid of the writetuple function and adjust the WRITETUP
macro to call the state's writetup function.  The WRITETUP usage in
mergeonerun() always has state->slabAllocatorUsed == true, so writetuple()
would never free the tuple or do any memory accounting.  The only call
path that needs memory accounting done is in dumptuples(), so let's just
do it manually there.

In passing, let's get rid of the state->memtupcount-- code that counts the
memtupcount down to 0 one tuple at a time inside the loop.  That seems to
be a rather inefficient way to set memtupcount to 0, so let's just zero it
after the loop instead.

Author: David Rowley
Discussion: https://postgr.es/m/CAApHDvqZXoDCyrfCzZJR0-xH+7_q+GgitcQiYXUjRani7h4j8Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1083f94dacde5f5b383ca8e18a85babb5cb5e77f

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 38 +++++++++++++++-----------------------
1 file changed, 15 insertions(+), 23 deletions(-)



Message-ID: <E1oTWp3-000pR6-KW@gemulon.postgresql.org>
Permalink:  ../E1oTWp3-000pR6-KW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oTWp3-000pR6-KW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Be smarter about freeing tuples during tuplesorts
  In-Reply-To: <E1oTWp3-000pR6-KW@gemulon.postgresql.org>
  References: <E1oTWp3-000pR6-KW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox