pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Port regress-python3-mangle.mk to Solaris "sed", redux.
Date: Thu, 01 Sep 2022 01:33:59 +0000
Message-ID: <E1oTZ5i-000qxq-P9@gemulon.postgresql.org> (raw)

Port regress-python3-mangle.mk to Solaris "sed", redux.

Per experimentation and buildfarm failures, Solaris' "sed"
has got some kind of problem with regexes that use both '*'
and '[[:alpha:]]'.  We can work around that by replacing
'[[:alpha:]]' with '[a-zA-Z]', which is plenty good enough
for our purposes, especially since this is only needed in
long-stable branches.

I chose to flat-out remove the second pattern of this sort,
's/except \([a-zA-Z][a-zA-Z.]*\), *\([a-zA-Z][a-zA-Z]*\):/except \1 as \2:/g'
because we haven't needed it since 8.4.

Follow-on to c3556f6fa, which probably missed catching this
because the problematic pattern was already gone when that
patch was written.

Patch v10-v12 only, as the problem manifests only there.
We have a line of dead code in v13-v14, which isn't worth
changing, and the whole mess is gone as of v15.

Discussion: https://postgr.es/m/165561.1661984701@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/02d060d0f75b15114df0cd31a6d1017e1fee86a1

Modified Files
--------------
src/pl/plpython/regress-python3-mangle.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



view thread (9+ messages)

Message-ID: <E1oTZ5i-000qxq-P9@gemulon.postgresql.org>
Permalink:  ../E1oTZ5i-000qxq-P9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oTZ5i-000qxq-P9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Port regress-python3-mangle.mk to Solaris "sed", redux.
  In-Reply-To: <E1oTZ5i-000qxq-P9@gemulon.postgresql.org>
  References: <E1oTZ5i-000qxq-P9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox