From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Adjust XML test case to avoid unstable behavior.
Date: Thu, 01 Sep 2022 02:21:43 +0000
Message-ID: <E1oTZpv-000rht-Dw@gemulon.postgresql.org> (raw)
Adjust XML test case to avoid unstable behavior.
Buildfarm member bowerbird is (inconsistently) showing different
results for this test case since we enabled ASLR for MSVC builds.
It's not very clear whether that's a bug in its version of libxml2
or the test case is relying on nominally-undefined behavior, ie the
ordering of results from XPath's node(). It seems quite unlikely
that it's *our* bug though, and what's more, using node() adds
nothing to the test coverage so far as our code is concerned.
So, tweak the test to not use node().
For the moment, only change HEAD because we've only seen the
problem there. Perhaps a case will emerge for back-patching.
Discussion: https://postgr.es/m/2655387.1661695793@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4ea07e7cf3c6b5ff7a7059c223fa54241533b0a5
Modified Files
--------------
src/test/regress/expected/xml.out | 4 ++--
src/test/regress/expected/xml_1.out | 2 +-
src/test/regress/expected/xml_2.out | 4 ++--
src/test/regress/sql/xml.sql | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Adjust XML test case to avoid unstable behavior.
In-Reply-To: <E1oTZpv-000rht-Dw@gemulon.postgresql.org>
References: <E1oTZpv-000rht-Dw@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox