pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.
Date: Fri, 02 Sep 2022 18:55:04 +0000
Message-ID: <E1oUBol-0017bz-IJ@gemulon.postgresql.org> (raw)

Fix oversight in recent MULTIEXPR_SUBLINK fix.

Commits 3f7323cbb et al missed the possibility that the Params
they are looking for could be buried under implicit coercions,
as well as other stuff that processIndirection() could add to
the original targetlist entry.  Copy the code in ruleutils.c
that deals with such cases.  (I thought about refactoring so
that there's just one copy; but seeing that we only need this
in old back branches, it seems not worth the trouble.)

Per off-list report from Andre Lin.  As before, only v10-v13
need the patch.

Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/18f51083c990c710bf7d5292965d0b3c0ef23dfa

Modified Files
--------------
src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++---
src/test/regress/expected/inherit.out  | 24 ++++++++++----------
src/test/regress/sql/inherit.sql       | 10 ++++-----
3 files changed, 54 insertions(+), 20 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1oUBol-0017bz-IJ@gemulon.postgresql.org>
Permalink:  ../E1oUBol-0017bz-IJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oUBol-0017bz-IJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.
  In-Reply-To: <E1oUBol-0017bz-IJ@gemulon.postgresql.org>
  References: <E1oUBol-0017bz-IJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox