pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. @ 2022-09-02 18:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-09-02 18:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c that deals with such cases. (I thought about refactoring so that there's just one copy; but seeing that we only need this in old back branches, it seems not worth the trouble.) Per off-list report from Andre Lin. As before, only v10-v13 need the patch. Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/18f51083c990c710bf7d5292965d0b3c0ef23dfa Modified Files -------------- src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++--- src/test/regress/expected/inherit.out | 24 ++++++++++---------- src/test/regress/sql/inherit.sql | 10 ++++----- 3 files changed, 54 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. @ 2022-09-02 18:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-09-02 18:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c that deals with such cases. (I thought about refactoring so that there's just one copy; but seeing that we only need this in old back branches, it seems not worth the trouble.) Per off-list report from Andre Lin. As before, only v10-v13 need the patch. Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/df92bc115ec8712cfdd0c7a26ef20b11914ab0a2 Modified Files -------------- src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++--- src/test/regress/expected/inherit.out | 24 ++++++++++---------- src/test/regress/sql/inherit.sql | 10 ++++----- 3 files changed, 54 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. @ 2022-09-02 18:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-09-02 18:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c that deals with such cases. (I thought about refactoring so that there's just one copy; but seeing that we only need this in old back branches, it seems not worth the trouble.) Per off-list report from Andre Lin. As before, only v10-v13 need the patch. Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/56dc4424472c2fa27f8822efe09d18c6935fe2a3 Modified Files -------------- src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++--- src/test/regress/expected/inherit.out | 24 ++++++++++---------- src/test/regress/sql/inherit.sql | 10 ++++----- 3 files changed, 54 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. @ 2022-09-02 18:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2022-09-02 18:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c that deals with such cases. (I thought about refactoring so that there's just one copy; but seeing that we only need this in old back branches, it seems not worth the trouble.) Per off-list report from Andre Lin. As before, only v10-v13 need the patch. Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/42d0d46f9825f7c3977e874380b093bb42a7e8ac Modified Files -------------- src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++--- src/test/regress/expected/inherit.out | 24 ++++++++++---------- src/test/regress/sql/inherit.sql | 10 ++++----- 3 files changed, 54 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-09-02 18:55 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-09-02 18:55 pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. Tom Lane <tgl@sss.pgh.pa.us> 2022-09-02 18:55 pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. Tom Lane <tgl@sss.pgh.pa.us> 2022-09-02 18:55 pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. Tom Lane <tgl@sss.pgh.pa.us> 2022-09-02 18:55 pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox