pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Backpatch nbtree page deletion hardening.
4+ messages / 1 participants
[nested] [flat]

* pgsql: Backpatch nbtree page deletion hardening.
@ 2022-09-05 18:21  Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2022-09-05 18:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a228cca46d7da9783e1b49ae6f1b6cc2fe338bcc

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Backpatch nbtree page deletion hardening.
@ 2022-09-05 18:21  Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2022-09-05 18:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/43e409cea4687ec1abdcfe82cd0b80a87a8d6adc

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Backpatch nbtree page deletion hardening.
@ 2022-09-05 18:21  Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2022-09-05 18:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7adc34832f24a247197899324e99ad042123ab09

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Backpatch nbtree page deletion hardening.
@ 2022-09-05 18:21  Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Geoghegan @ 2022-09-05 18:21 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cfe41f9766a1dee058932fcab93ddade004e61da

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-09-05 18:21 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 18:21 pgsql: Backpatch nbtree page deletion hardening. Peter Geoghegan <pg@bowt.ie>
2022-09-05 18:21 pgsql: Backpatch nbtree page deletion hardening. Peter Geoghegan <pg@bowt.ie>
2022-09-05 18:21 pgsql: Backpatch nbtree page deletion hardening. Peter Geoghegan <pg@bowt.ie>
2022-09-05 18:21 pgsql: Backpatch nbtree page deletion hardening. Peter Geoghegan <pg@bowt.ie>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox