pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Backpatch nbtree page deletion hardening.
Date: Mon, 05 Sep 2022 18:21:19 +0000
Message-ID: <E1oVGil-001ar6-CW@gemulon.postgresql.org> (raw)

Backpatch nbtree page deletion hardening.

Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy
opclasses.  VACUUM's inability to locate a to-be-deleted page's downlink
in the parent page was logged instead of throwing an error.  VACUUM
could just press on with vacuuming the index, and vacuuming the table as
a whole.

There are now anecdotal reports of this error causing problems that were
much more disruptive than the underlying index corruption ever could be.
Anything that makes VACUUM unable to make forward progress against one
table/index ultimately risks making the system enter xidStopLimit mode.
There is no good reason to take any chances here, so backpatch the
hardening commit.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm9HR6Pow=t-iQa57zT8qmX6_M4h14F-pTtb=xFDW5FBA@mail.gmail.com
Backpatch: 10-13 (all supported versions that lacked the hardening)

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cfe41f9766a1dee058932fcab93ddade004e61da

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)



view thread (4+ messages)

Message-ID: <E1oVGil-001ar6-CW@gemulon.postgresql.org>
Permalink:  ../E1oVGil-001ar6-CW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oVGil-001ar6-CW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Backpatch nbtree page deletion hardening.
  In-Reply-To: <E1oVGil-001ar6-CW@gemulon.postgresql.org>
  References: <E1oVGil-001ar6-CW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox