pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix new pg_publication_tables query.
Date: Tue, 06 Sep 2022 22:00:45 +0000
Message-ID: <E1oVgce-001lHH-Jc@gemulon.postgresql.org> (raw)

Fix new pg_publication_tables query.

The addition of published column names forgot to filter on attisdropped,
leading to cases where you could see "........pg.dropped.1........"
or the like as a reportedly-published column.

While we're here, rewrite the new subquery to get a more efficient plan
for it.

Hou Zhijie, per report from Jaime Casanova.  Back-patch to v15 where
the bug was introduced.  (Sadly, this means we need a post-beta4
catversion bump before beta4 has even hit the streets.  I see no
good alternative though.)

Discussion: https://postgr.es/m/Yxa1SU4nH2HfN3/i@ahch-to

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e25631265a233e0c315458b206e419eca69fdb22

Modified Files
--------------
src/backend/catalog/system_views.sql | 9 ++++-----
src/include/catalog/catversion.h     | 2 +-
src/test/regress/expected/rules.out  | 9 ++-------
3 files changed, 7 insertions(+), 13 deletions(-)



view thread (2+ messages)

Message-ID: <E1oVgce-001lHH-Jc@gemulon.postgresql.org>
Permalink:  ../E1oVgce-001lHH-Jc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1oVgce-001lHH-Jc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix new pg_publication_tables query.
  In-Reply-To: <E1oVgce-001lHH-Jc@gemulon.postgresql.org>
  References: <E1oVgce-001lHH-Jc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox