pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix new pg_publication_tables query. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix new pg_publication_tables query. @ 2022-09-06 22:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-09-06 22:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix new pg_publication_tables query. The addition of published column names forgot to filter on attisdropped, leading to cases where you could see "........pg.dropped.1........" or the like as a reportedly-published column. While we're here, rewrite the new subquery to get a more efficient plan for it. Hou Zhijie, per report from Jaime Casanova. Back-patch to v15 where the bug was introduced. (Sadly, this means we need a post-beta4 catversion bump before beta4 has even hit the streets. I see no good alternative though.) Discussion: https://postgr.es/m/Yxa1SU4nH2HfN3/i@ahch-to Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/20b6847176976da9cae6103475b967e6c2971898 Modified Files -------------- src/backend/catalog/system_views.sql | 9 ++++----- src/include/catalog/catversion.h | 2 +- src/test/regress/expected/rules.out | 9 ++------- 3 files changed, 7 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix new pg_publication_tables query. @ 2022-09-06 22:00 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-09-06 22:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix new pg_publication_tables query. The addition of published column names forgot to filter on attisdropped, leading to cases where you could see "........pg.dropped.1........" or the like as a reportedly-published column. While we're here, rewrite the new subquery to get a more efficient plan for it. Hou Zhijie, per report from Jaime Casanova. Back-patch to v15 where the bug was introduced. (Sadly, this means we need a post-beta4 catversion bump before beta4 has even hit the streets. I see no good alternative though.) Discussion: https://postgr.es/m/Yxa1SU4nH2HfN3/i@ahch-to Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e25631265a233e0c315458b206e419eca69fdb22 Modified Files -------------- src/backend/catalog/system_views.sql | 9 ++++----- src/include/catalog/catversion.h | 2 +- src/test/regress/expected/rules.out | 9 ++------- 3 files changed, 7 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-09-06 22:00 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-09-06 22:00 pgsql: Fix new pg_publication_tables query. Tom Lane <tgl@sss.pgh.pa.us> 2022-09-06 22:00 pgsql: Fix new pg_publication_tables query. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox